EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39678 )
Change subject: mb/google/deltaur: Provide initial devicetree
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau...
File src/mainboard/google/deltaur/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau...
PS3, Line 68: register "PcieClkSrcClkReq[2]" = "8"
whoops, this should be 2..
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau...
PS3, Line 73: register "PcieClkSrcUsage[6]" = "PCIE_CLK_NOTUSED"
There are only 7 total, so max index of 6, see https://review.coreboot.org/cgit/coreboot. […]
yes, because I saw the 8...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I911ec08b0db3647d131113a138fb74a55612fd62
Gerrit-Change-Number: 39678
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Chowski
chowski@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 20 Mar 2020 16:28:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment