Attention is currently required from: V Sowmya, Sugnan Prabhu S, Tim Wawrzynczak, Balaji Manigandan, Aamir Bohra.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49478 )
Change subject: mb/intel/shadowmountain: Add flash layout for shadowmountain
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/intel/shadowmountain/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/49478/comment/4de755df_c5d9fc62
PS1, Line 6: SI_BIOS@0x1400000 0xc00000 {
There is no specific reason skip it and i used the same fmap from the adlrvp. […]
i think the idea is here to create 12MB BIOS region hence started from bottom alignment
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7073d9c783684051e33e7a33eca50007d286bb00
Gerrit-Change-Number: 49478
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Fri, 22 Jan 2021 03:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: V Sowmya
v.sowmya@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment