Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34924 )
Change subject: google/stout: Use MAYBE_STATIC
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34924/2/src/mainboard/google/stout/...
File src/mainboard/google/stout/chromeos.c:
https://review.coreboot.org/c/coreboot/+/34924/2/src/mainboard/google/stout/...
PS2, Line 85: if (ec_rec_flag_good)
: return ec_in_rec_mode;
Move this up before line 77?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34924
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11027acb11a4656536384134d0caebd14b63770c
Gerrit-Change-Number: 34924
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 18 Aug 2019 21:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment