Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42455 )
Change subject: nb/intel/sandybridge/gma.c: Correct deasserting force wake on IVB
......................................................................
Patch Set 2:
Patch Set 2:
(2 comments)
I know it's a lot of work, but I think all the changes in this
series (even individual bits) should be tested separately if they
fix anything.
It's quite difficult to do given that we have no idea what these bits mean. Or by testing you mean running it for a couple of days and making sure the system is still stable?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42455
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31f8cddb9408d0c23c558b51f5d1f8787f0b700f
Gerrit-Change-Number: 42455
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 21 Jun 2020 18:33:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment