Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46407 )
Change subject: soc/mediatek/mt8192: Enable DCM
......................................................................
Patch Set 40:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46407/40/src/soc/mediatek/mt8192/in...
File src/soc/mediatek/mt8192/include/soc/pll.h:
https://review.coreboot.org/c/coreboot/+/46407/40/src/soc/mediatek/mt8192/in...
PS40, Line 310: INFRACFG_AO_AXIMEM_BUS_DCM_REG0_MASK = ((0x1f << 12) | \
Avoid unnecessary line continuations
Please fix all of these.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46407
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5528d176b6bb1f9a5960de981766235510e6ebf1
Gerrit-Change-Number: 46407
Gerrit-PatchSet: 40
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Assignee: Michael Kao
michael.kao@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Kao
michael.kao@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 14 Dec 2020 06:59:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment