HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33504 )
Change subject: MSR: Move common intel's MSRs to common place ......................................................................
Patch Set 4:
(2 comments)
not easy task .... we have: - x86/amd64 common MSRs - some common intel's MSRs - platform's specific MSRs (for intel) - AMD seems to be ok (probably if we remove "I32_" from x86/64 MSRs)
https://review.coreboot.org/c/coreboot/+/33504/4/src/include/cpu/x86/msr.h File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/33504/4/src/include/cpu/x86/msr.h@1... PS4, Line 19: FEATURE_CONTROL_LOCK_BIT (1 << 0) : #define FEATURE_ENABLE_VMX (1 << 2) : #define SMRR_ENABLE (1 << 3) : #define CPUID_VMX (1 << 5) : #define CPUID_SMX (1 << 6) linked to IA32_FEATURE_CONTROL
https://review.coreboot.org/c/coreboot/+/33504/4/src/include/cpu/x86/msr.h@2... PS4, Line 24: CPUID_DCA (1 << 18) this is for IA32_PLATFORM_DCA_CAP