Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39805 )
Change subject: acpi: Bump FADT to revision 6
......................................................................
Patch Set 1:
Patch Set 1:
It looks like x_gpe0_blk needs to be set, but it's unclear how as the GPE0 register is too big.
Looking at apica reference code it ignores the x_gpe0_blk length (which would overflow anyway), but the commit message on lynxpoint LP states otherwise.
ah yes, I missed the ! on that section when I was comparing to BDW. Copying the values for x_gpe0_blk from BDW fixes Lynxpoint-LP
side note: seems that only the common FADT implementation is setting sleep_control/sleep_status_reg.bit_width to 8. That should probably be set across the board in all the platform implementations to be in compliance with the spec. (though it seems many of those could be be dropped and use the common implementation)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39805
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic649040025cd09ed3e490a521439ca4e681afbbf
Gerrit-Change-Number: 39805
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Mar 2020 15:47:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment