9 Sep
2020
9 Sep
'20
10:07 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45213 )
Change subject: chromeos: Provide common watchdog reboot support in romstage ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45213/3/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45213/3/src/vendorcode/google/chrom... PS3, Line 18: romstage-y += watchdog.c This patch needs to be reordered before the others so that mark_watchdog_tombstone() is already available in the patch that adds a call to it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a1f1411e9d58a0738e0e8057f5b1ad049bf03e3
Gerrit-Change-Number: 45213
Gerrit-PatchSet: 3
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 10 Sep 2020 01:07:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment