Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31635 )
Change subject: soc/intel/skylake: nhlt: Add 24-bit blobs for Max98373 ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/31635/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/31635/5//COMMIT_MSG@12 PS5, Line 12: same the same
https://review.coreboot.org/c/coreboot/+/31635/5//COMMIT_MSG@19 PS5, Line 19: to match with 24-bit : topology firmware to match the 24-bit topology firmware
https://review.coreboot.org/c/coreboot/+/31635/5/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/nocturne/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/31635/5/src/mainboard/google/poppy/... PS5, Line 405: register "vmon_slot_no" = "1" What does this have to do with the firmware change?