[coreboot-gerrit] Change in coreboot[master]: cpu/intel/slot_1: Move to C_ENVIRONMENT_BOOTBLOCK

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36774 )

Change subject: cpu/intel/slot_1: Move to C_ENVIRONMENT_BOOTBLOCK
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36774/1/src/cpu/intel/slot_1/Makefi... 
File src/cpu/intel/slot_1/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/36774/1/src/cpu/intel/slot_1/Makefi... 
PS1, Line 31: bootblock-y += ../../x86/early_reset.S
> Last is not needed?

Done

https://review.coreboot.org/c/coreboot/+/36774/1/src/southbridge/intel/i8237... 
File src/southbridge/intel/i82371eb/bootblock.c:

https://review.coreboot.org/c/coreboot/+/36774/1/src/southbridge/intel/i8237... 
PS1, Line 54: 	/* Enable access to the whole ROM, disable ROM write access. */
> > This probably limits bootblock size to 64 KiB. […]

Added a preprocessor assertion + a comment.