Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34840 )
Change subject: intel/smm: Provide common smm_relocation_params ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34840/7/src/cpu/x86/Makefile.inc File src/cpu/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34840/7/src/cpu/x86/Makefile.inc@9 PS7, Line 9: # This is hacky. Indeed. Can we not conditionalize it?
https://review.coreboot.org/c/coreboot/+/34840/7/src/include/cpu/intel/smm_r... File src/include/cpu/intel/smm_reloc.h:
https://review.coreboot.org/c/coreboot/+/34840/7/src/include/cpu/intel/smm_r... PS7, Line 88: static inline void write_smrr(struct smm_relocation_params *relo_params) const on the types for these files?