Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35596 )
Change subject: mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35596/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35596/2/src/mainboard/google/hatch/...
PS2, Line 61: register "PchPmSlpS0Vm075VSupport" = "1"
Don't you also need to set SlpS0VmRuntimeControl?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35596
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia02ff8823883489b36349457213409496f082f36
Gerrit-Change-Number: 35596
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Sep 2019 16:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment