Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC
......................................................................
Patch Set 2: -Code-Review
(1 comment)
Please rebase these changes on https://review.coreboot.org/c/coreboot/+/45647
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v...
PS2, Line 15: H5ANAG6NDMR-XNC, 7
You can leave you comment for HW in https://partnerissuetracker.corp.google.com/issues/165611994. […]
I checked and in this case there are no other existing compatible ids for this part, so removing the id here won't make a material difference. I'll also leave a comment on the bug for future reference.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf613d54bf23b637e38917937ce3e78702b26a28
Gerrit-Change-Number: 45682
Gerrit-PatchSet: 2
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Sep 2020 15:51:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment