Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33652 )
Change subject: arch/x86/acpi: Add os.asl ......................................................................
Patch Set 1:
(2 comments)
Patch Set 1:
(4 comments)
Patch Set 1: Code-Review-1
(4 comments)
I don't like this. Is there a better approach?
NB this -1 is not blocking the change from being merged.
This was originally part of stoneyridge ACPI code, Paul Manzel asked to have it available for everyone.
Ack
https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl File src/arch/x86/acpi/os.asl:
https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl@90 PS1, Line 90: If(SCPM(local0, "Microsoft WindowsME: Millennium Edition"))
Probably not. Same for Windows NT. I just am not sure if anyone still uses either OS. […]
I believe the "Windows NT" ACPI name is still in use. I'd be more worried about HP-UX and OpenVMS.
https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl@94 PS1, Line 94: If(SCPM(local0, "Linux"))
The work around is in line 24, which verifies if _OSI is implemented. […]
What I mean is that I would leave out all queries for "Linux". Linux documentation suggests only using _OSI to query for specific capabilities, and that would be device-specific.