HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39537 )
Change subject: nb/intel/i945: Refactor sdram_set_channel_mode()
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39537/3/src/northbridge/intel/i945/...
File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/39537/3/src/northbridge/intel/i945/...
PS3, Line 1584: } else
What if sysinfo->dimm[1] is populated?
Here we are in Single-Channel. so if DIMM0 is not populated, it means that DIMM1 is populated đ
so here you are đ
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39537
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7574bc4a1dbb55d12dec9be17e403a2f448c16c0
Gerrit-Change-Number: 39537
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 15 Mar 2020 06:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment