Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34136 )
Change subject: soc/intel/*/include: Add support to get LPSS controllers list from SOC ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34136/3/src/soc/intel/apollolake/in... File src/soc/intel/apollolake/include/soc/soc_chip.h:
https://review.coreboot.org/c/coreboot/+/34136/3/src/soc/intel/apollolake/in... PS3, Line 22: soc_lpss_controllers Where is the implementation for apollolake?
https://review.coreboot.org/c/coreboot/+/34136/3/src/soc/intel/cannonlake/in... File src/soc/intel/cannonlake/include/soc/soc_chip.h:
https://review.coreboot.org/c/coreboot/+/34136/3/src/soc/intel/cannonlake/in... PS3, Line 22: soc_lpss_controllers Probably better to put this in lpss.h under intel/common?
https://review.coreboot.org/c/coreboot/+/34136/3/src/soc/intel/skylake/inclu... File src/soc/intel/skylake/include/soc/soc_chip.h:
https://review.coreboot.org/c/coreboot/+/34136/3/src/soc/intel/skylake/inclu... PS3, Line 22: soc_lpss_controllers Where is the implementation for skylake?