Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32539 )
Change subject: soc/intel/cannonlake/acpi: Add board level s0ix call back
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/32539/1/src/soc/intel/cannonlake/acpi/lpit.a...
File src/soc/intel/cannonlake/acpi/lpit.asl:
https://review.coreboot.org/#/c/32539/1/src/soc/intel/cannonlake/acpi/lpit.a...
PS1, Line 79: 1
This should be 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32539
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I404f388b19355ae89b36d1fb07f9fb4f97eb3b2d
Gerrit-Change-Number: 32539
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 03 May 2019 05:35:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment