Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39460 )
Change subject: tgl boards: Configure retimer Aux orientation ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39460/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39460/2//COMMIT_MSG@7 PS2, Line 7: mainboard: Set Tiger Lake platforms to have retimer config Aux orientation
Please look through `git log --oneline` what prefixes are common. […]
Done
https://review.coreboot.org/c/coreboot/+/39460/2//COMMIT_MSG@12 PS2, Line 12: a retimers
a retimer?
Done
https://review.coreboot.org/c/coreboot/+/39460/2//COMMIT_MSG@14 PS2, Line 14: this setting is changing on the SOC side.
Please re-flow for 72/75 characters, and add one blank line between paragraphs.
Done
https://review.coreboot.org/c/coreboot/+/39460/2//COMMIT_MSG@12 PS2, Line 12: account for ports that do not have a retimers this setting is in the process of : being documented in the TGL EDS and we can update once it is fully understood what : this setting is changing on the SOC side.
New sentence starting with *this setting*?
Done
https://review.coreboot.org/c/coreboot/+/39460/2//COMMIT_MSG@19 PS2, Line 19: type-c
Please spell it consisently.
Done
https://review.coreboot.org/c/coreboot/+/39460/2//COMMIT_MSG@20 PS2, Line 20: orientation.
On which board?
Done