Attention is currently required from: Bora Guvendik, Furquan Shaikh, Selma Bensaid, Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Angel Pons, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50996 )
Change subject: mb/adlrvp: Fix DDR5 Boot issue ......................................................................
Patch Set 14:
(22 comments)
File src/soc/intel/alderlake/meminit.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/cd5419c1_03d67ea1 PS14, Line 222: static const int spd_array[] = { 0xA0, 0xA2, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xA4, 0xA6, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/a0d99870_01f73c1d PS14, Line 223: 0x0, 0x0, 0x0, 0x0, 0x0, 0x0 }; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/e9fdc8f3_b445d5f9 PS14, Line 225: for (int i = 0; i < 16; i++) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/71c401fb_5128d542 PS14, Line 225: for (int i = 0; i < 16; i++) suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/1a818022_baa3171d PS14, Line 226: mem_cfg->SpdAddressTable[i] = spd_array[i]; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/d9272dfe_827c14ae PS14, Line 226: mem_cfg->SpdAddressTable[i] = spd_array[i]; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/4c6b5faf_23011023 PS14, Line 266: if (!smbus_address_valid) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/ef3ef5bd_08f68e16 PS14, Line 266: if (!smbus_address_valid) { suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/faa7f597_988d2c9a PS14, Line 267: mem_populate_channel_data(&soc_mem_cfg[mb_cfg->type], spd_info, half_populated, &data); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/4e7298c1_6f5720ac PS14, Line 267: mem_populate_channel_data(&soc_mem_cfg[mb_cfg->type], spd_info, half_populated, &data); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/8bd68f9f_803cee68 PS14, Line 267: mem_populate_channel_data(&soc_mem_cfg[mb_cfg->type], spd_info, half_populated, &data); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/4f494712_14c2fdd3 PS14, Line 268: mem_init_spd_upds(mem_cfg, &data); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/def993d9_6bc950a9 PS14, Line 268: mem_init_spd_upds(mem_cfg, &data); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/17d1aa39_891abc84 PS14, Line 269: } else { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/fec9a130_baf9db2c PS14, Line 269: } else { suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/ca8c4398_5103cde0 PS14, Line 270: mem_init_smbus_fill_upd(mem_cfg); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/0a2efb80_34c52761 PS14, Line 270: mem_init_smbus_fill_upd(mem_cfg); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/f1c97014_50540783 PS14, Line 271: mem_init_dq_upds(mem_cfg, &data, mb_cfg, dq_dqs_auto_detect); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/d6eca2a6_4f658000 PS14, Line 271: mem_init_dq_upds(mem_cfg, &data, mb_cfg, dq_dqs_auto_detect); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/9722b579_41b54d03 PS14, Line 272: mem_init_dqs_upds(mem_cfg, &data, mb_cfg, dq_dqs_auto_detect); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/c4c1ab2c_fd2f945f PS14, Line 272: mem_init_dqs_upds(mem_cfg, &data, mb_cfg, dq_dqs_auto_detect); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628): https://review.coreboot.org/c/coreboot/+/50996/comment/66ba295a_c555caad PS14, Line 273: } please, no spaces at the start of a line