Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43979 )
Change subject: drivers/intel/fsp2_0: Change boot state notification
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43979/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43979/4//COMMIT_MSG@21
PS4, Line 21: This prevents code corruption of payload. At this stage of boot, there
: is no concept of memory management, therefore FSP can use any memory it
: needs.
What memory is FSP using which is causing corruption? Coreboot already reserves the memory where FSP is loaded. I don't think it should be accessing anything outside that reservation. If it is, then it seems like a FSP bug.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43979
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I122edc12abf992cb3e5ec53747a7cef9c94aee8e
Gerrit-Change-Number: 43979
Gerrit-PatchSet: 4
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 28 Jul 2020 06:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment