Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37214 )
Change subject: lib: Fix FMAP cache on FSP1.0 platforms
......................................................................
Patch Set 2:
If you really wanted to make it usable instead you could check stage macros to enable it only during ENV_BOOTBLOCK and ENV_VERSTAGE, but I don't think that's worth it. (Truth be told, I would expect the feature doesn't add much on Intel platforms in general since the SPI memory mapping hardware is probably already caching the area internally anyway. I mostly wrote it for Arm and as a pre-requisite that we'll eventually need for TOCTOU-safe verification.)
yeah looks like car_active does not even work properly on fsp1.0. ok, killing this, thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: I9f64c26650fa4c397a0e4835e470ab41922e1290
Gerrit-Change-Number: 37214
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Nov 2019 01:12:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment