[coreboot-gerrit] Change in coreboot[master]: mb/*/*{i440BX}: Enable console in bootblock

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36775 )

Change subject: mb/*/*{i440BX}: Enable console in bootblock
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36775/5/src/cpu/intel/slot_1/Kconfi... 
File src/cpu/intel/slot_1/Kconfig:

https://review.coreboot.org/c/coreboot/+/36775/5/src/cpu/intel/slot_1/Kconfi... 
PS5, Line 44: 	hex
> how about
> default 0x2000 if !BOOTBLOCK_CONSOLE

I'll check if it's also fine with the XIP cache code.

https://review.coreboot.org/c/coreboot/+/36775/5/src/mainboard/asus/p2b-ls/e... 
File src/mainboard/asus/p2b-ls/early_init.c:

https://review.coreboot.org/c/coreboot/+/36775/5/src/mainboard/asus/p2b-ls/e... 
PS5, Line 46: #endif
> Why guard it at all?

early_smbus.c needs to be linked in the bootblock and smbus_read_byte needs to be guarded in the header to not conflict in ramstage.