Hello William Wei, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Tim Wawrzynczak, Duncan Laurie, Jes Klinke,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41797
to look at the new patch set (#9).
Change subject: mb/google/volteer: move volteer-specific GPIOs to variant gpio.c ......................................................................
mb/google/volteer: move volteer-specific GPIOs to variant gpio.c
- Move the GPIOs that are likely to be volteer-specific (mostly peripherals) to reside in variants/volteer/gpio.c so that variants don't have to override too many GPIO settings.
- Modify malefor's gpio.c to adjust for the changes to baseboard's gpio.c.
- Remove unused GPP_C3 (USB4_SMB_SCL) and GPP_C4 (USB4_SMB_SCA) settings.
- Remove unused GPP_D9, GPP_D10, GPP_D11, and GPP_D12 settings.
- Remove unused GPP_E8 (SLP_S0IX), COEX, WWAN, and SNDW related settings for malefor.
- Remove unused GPP_R4 (HDA_RST_L) setting.
BUG=b:157597158 TEST="emerge-volteer coreboot chromeos-bootimage", flash and boot volteer SKU4 to kernel.
Change-Id: Ib2f384f539d55a3a8d4a7608336ef22aca3d8c4f Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/gpio.c M src/mainboard/google/volteer/variants/malefor/gpio.c A src/mainboard/google/volteer/variants/volteer/Makefile.inc A src/mainboard/google/volteer/variants/volteer/gpio.c 4 files changed, 536 insertions(+), 474 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/41797/9