Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37316 )
Change subject: mb/google/poppy: auto-select correct audio blobs ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37316/1/src/mainboard/google/poppy/... File src/mainboard/google/poppy/Kconfig:
https://review.coreboot.org/c/coreboot/+/37316/1/src/mainboard/google/poppy/... PS1, Line 49: config INCLUDE_NHLT_BLOBS
Is this really to be selected along with one of the other options? It […]
you appear to be correct - I was confusing this with the SKL/glados implementation where it was a base + variant setup. will abandon