Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48466 )
Change subject: drivers/intel/fsp2_0: Use coreboot postcar with FSP-T
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/48466/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48466/1//COMMIT_MSG@12
PS1, Line 12: a few
nit: several
https://review.coreboot.org/c/coreboot/+/48466/1//COMMIT_MSG@14
PS1, Line 14: Having
Missing a verb: *Allows* having ...
https://review.coreboot.org/c/coreboot/+/48466/1//COMMIT_MSG@17
PS1, Line 17: This removes the need to find
nit: Avoids/Prevents having to find
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48466
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cf10c7580f3183bfee1cd3c827901cbcf695db7
Gerrit-Change-Number: 48466
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 16:51:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment