Attention is currently required from: Jarried Lin.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email )
Change subject: mb/google/rauru: Implement SKU ID ......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/google/rauru/boardid.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/d9ffef33_09764510?usp... : PS7, Line 66: get_adc_index(SKU_ID_LOW_CHANNEL))
I'd like to suggest the 0x7FFFXFFF and take "X" as storage type usage, […]
Synced with @knoxchiou@google.com, ``` bit[7:0] reserved for panel type, bit[8] reserved for CPU type, bit[11:9] reserved for storage type. ```
@jarried.lin@mediatek.com Please add a `storage_id` function similar to `panel_id` in corsola/geralt and declare storage_id in `storage.h`.
Combine storage_id with unprovisioned value. ```
cached_sku_code = CROS_SKU_UNPROVISIONED; cached_sku_code &= ~(7 << 8); cached_sku_code |= (storage_id() << 8); ```
File src/mainboard/google/rauru/boardid.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/d04a616d_67b66644?usp... : PS8, Line 60: cached_sku_code == CROS_SKU_UNKNOWN) `|| cached_sku_code == CROS_SKU_UNPROVISIONED`