V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43791 )
Change subject: soc/intel/jasperlake: Add FSP UPDs for minimum assertion widths ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43791/5/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/43791/5/src/soc/intel/jasperlake/fs... PS5, Line 112: asst
assrt? […]
Done
https://review.coreboot.org/c/coreboot/+/43791/5/src/soc/intel/jasperlake/fs... PS5, Line 135: asst
assrt? see it in other places as well.
Done
https://review.coreboot.org/c/coreboot/+/43791/5/src/soc/intel/jasperlake/fs... PS5, Line 168: get_pm_pwr_cyc_dur
good to add a note here: […]
Done
https://review.coreboot.org/c/coreboot/+/43791/5/src/soc/intel/jasperlake/fs... PS5, Line 191: printk (BIOS_DEBUG,
space prohibited between function name and open parenthesis '('
done
https://review.coreboot.org/c/coreboot/+/43791/7/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/43791/7/src/soc/intel/jasperlake/fs... PS7, Line 112: /* This funtion returns the higher assertion duration of the SLP_Sx assertion widths */
'funtion' may be misspelled - perhaps 'function'?
done