build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39615 )
Change subject: sc7180: Add display hardware pipe line initialization [patch 3 of 3] ......................................................................
Patch Set 1:
(26 comments)
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... File src/soc/qualcomm/sc7180/display/mdss.c:
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 30: *pinfo); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 70: uint32_t *left_pipe, uint32_t *right_pipe) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 91: !pinfo->mipi.dual_dsi && code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 92: !pinfo->lcdc.split_display; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 101: *ctl0_reg_val |= BIT(12)| BIT(11) | BIT(6) | BIT(7); need consistent spacing around '|' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 105: *ctl1_reg_val |= BIT(12)| BIT(7); need consistent spacing around '|' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 114: *ctl0_reg_val |= BIT(0)| BIT(1) |BIT(6) | BIT(7); need consistent spacing around '|' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 114: *ctl0_reg_val |= BIT(0)| BIT(1) |BIT(6) | BIT(7); need consistent spacing around '|' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 116: *ctl0_reg_val |= BIT(0)| BIT(6); need consistent spacing around '|' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 131: struct msm_panel_info *pinfo, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 132: uint32_t pipe_base) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 155: else { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 286: itp.h_back_porch; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 290: itp.v_back_porch) * code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 291: hsync_period + itp.hsync_skew; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 294: + itp.hsync_skew - 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 381: fetch_start = (v_total - prefetch_avail) * h_total+ h_total + 1; need consistent spacing around '+' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 384: fetch_enable |= BIT(23); //TODO: this shoudld not be enabled ? 'shoudld' may be misspelled - perhaps 'should'?
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 415: left_staging_level =BIT(24); //attach border spaces required around that '=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 416: right_staging_level=BIT(24); spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 449: writel(0x00ff0000, MDP_VP_0_MIXER_1_BASE + LAYER_0_BLEND0_CONST_ALPHA(i)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 478: int is_main_ctl) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 498: uint32_t *intf_base, uint32_t *sintf_base) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 510: struct fbcon_config *fb) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 558: MDP_DSC_0_BASE, true, true); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/1/src/soc/qualcomm/sc7180/dis... PS1, Line 608: if (pinfo->lcdc.dual_pipe && !pinfo->lcdc.dst_split){ space required before the open brace '{'