Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31200 )
Change subject: soc/intel/apl: Call mca_configure() on cold boots only
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31200/3/src/soc/intel/apollolake/cpu.c
File src/soc/intel/apollolake/cpu.c:
https://review.coreboot.org/#/c/31200/3/src/soc/intel/apollolake/cpu.c@76
PS3, Line 76: IS_ENABLED(SOC_INTEL_COMMON_BLOCK_SGX
What is the dependency to SGX here? If I get it right we are dealing with the internal machine check […]
The call was added for SGX support in dc194e2bc4e. I don't
know the details nor where to look them up. Will add Pratik,
maybe he can tell us more.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31200
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09b4a2fe22267d7318951aac20a3ea566403492e
Gerrit-Change-Number: 31200
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Feb 2019 08:56:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment