Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33357 )
Change subject: soc/intel/block/cpu: Make MP init options mutually exclusive
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
do you have any mean to test this ?
It looks like these Kconfig options poorly reflect what the code does.
USE_COREBOOT_NATIVE_MP_INIT is never used in the code, so selecting it or not would result in the code attempting to use the native MP init, unless USE_INTEL_FSP_MP_INIT is selected.
It is probably better do drop that option all together.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33357
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65b80805d3cd7b66f8c9f878d3c741b98f24288d
Gerrit-Change-Number: 33357
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 10 Jun 2019 09:59:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment