Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37311 )
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 5:
Matt, have you verified the dmesg logging for the atlas and nocturne variants?
The vbt on these boards differs from the others (the config size is 39 vs 38 bytes). I have a similar vbt (Kabylake FSP 3.7.1. or newer) and get an error message indicating the config size reported by the VBT is not correct.
This at least doesn't look nice. Before reporting this to Intel I wanted to make sure I am not the only one with this problem.
I don't have Atlas here, but on Nocturne I do see a log entry (not flagged as an error) with drm debugging enabled for function parse_general_definitions: 'Expected child device config size for VBT version 221 not known; assuming 39.' I'm not seeing any functional impairment though. FSP (KBL 3.7.6) doesn't seem to have an issue though, both internal and external displays are initialized correctly at boot.
Thanks for the feednack, so you are seeing the same thing. You are right it's not a problem functionality wise. At least not at this point in time. The additional byte is not copied so nothing is overwritten and the additional byte (DP max link speed) is not used yet in the BSF but the output looks ugly and is intended to trigger some action. So I will report it to Intel.