Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31621 )
Change subject: soc/intel/cannonlake: Move common definitions to a header file ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31621/4/src/soc/intel/cannonlake/include/soc... File src/soc/intel/cannonlake/include/soc/gpio_common.h:
https://review.coreboot.org/#/c/31621/4/src/soc/intel/cannonlake/include/soc... PS4, Line 19: #define GPIORXSTATE_SHIFT 1 : #define GPIOTXSTATE_MASK 0x1 : #define GPIOPADMODE_MASK 0xC00 : #define GPIOPADMODE_SHIFT 10 : #define GPIOTXBUFDIS_MASK 0x100 : #define GPIORXBUFDIS_MASK 0x200 These are also present in src/soc/intel/common/block/include/intelblocks/gpio_defs.h, I think we can just use those.