Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81681?usp=email )
Change subject: soc/intel/xeon_sp: Add iio_ioapic.c
......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS3:
Thanks for the good catches, updated!
File src/soc/intel/xeon_sp/iio_ioapic.c:
https://review.coreboot.org/c/coreboot/+/81681/comment/26991c1b_81959378 :
PS1, Line 10: XEON_SP_HAVE_IIO_IOAPIC
drop?
Done
https://review.coreboot.org/c/coreboot/+/81681/comment/7d4bb5b7_8dc9730f :
PS1, Line 10: 8 + 1
probably should be CONFIG_MAX_SOCKET * MAX_IIO_STACK + 1 ?
Done
https://review.coreboot.org/c/coreboot/+/81681/comment/21accb3a_8ca97f72 :
PS1, Line 30: XEON_SP_HAVE_IIO_IOAPIC
condition is always false
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81681?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I59022b7685539491604724ef3b550da1cfd53f13
Gerrit-Change-Number: 81681
Gerrit-PatchSet: 3
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 08 Apr 2024 08:16:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment