Attention is currently required from: David Wu, Tim Wawrzynczak, Alan Huang.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58041 )
Change subject: mb/google/brask/var/brask: Configure GPIOs according to schematics
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/brask/gpio.c:
https://review.coreboot.org/c/coreboot/+/58041/comment/83928a16_8619bf3d
PS3, Line 64: const struct pad_config *variant_gpio_override_table(size_t *num)
: {
: *num = ARRAY_SIZE(override_gpio_table);
: return override_gpio_table;
: }
:
Do you need to add this? Do you miss something in the override_gpio_table[], the override_gpio_table[] is empty?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58041
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71026565b876739d2a08ef79940f47c476ca70a8
Gerrit-Change-Number: 58041
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 30 Sep 2021 13:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment