Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36207 )
Change subject: ec/google/chromeec: Add EC driver support for software sync
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36207/13/src/ec/google/chromeec/ec....
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/36207/13/src/ec/google/chromeec/ec....
PS13, Line 682: EC_VER_FLASH_WRITE
That said, if you really want this to support older boards for some reason <snip> […]
I don't see how you think this is less functional; coreboot has never performed EC software sync before, and currently depthcharge still handles EC software sync as well (intended for those devices that have the "slow" EC update so that a screen can be shown to the user). Please add us on your proposed patches.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36207
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d3c5184dbe96f04b92878f2c19c7875503a910a
Gerrit-Change-Number: 36207
Gerrit-PatchSet: 13
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Nov 2019 15:42:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment