Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32757 )
Change subject: soc/intel/broadwell/romstage: Clean up unused bist variable ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Good enough for this weird code flow.
https://review.coreboot.org/#/c/32757/1/src/soc/intel/broadwell/include/soc/... File src/soc/intel/broadwell/include/soc/romstage.h:
https://review.coreboot.org/#/c/32757/1/src/soc/intel/broadwell/include/soc/... PS1, Line 25: So the value was never consumed anyway? ;)
https://review.coreboot.org/#/c/32757/1/src/soc/intel/broadwell/romstage/rom... File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/#/c/32757/1/src/soc/intel/broadwell/romstage/rom... PS1, Line 66: asmlinkage void car_stage_entry(void) : { : struct romstage_params rp; : : post_code(0x30); : : /* Start console drivers */ : console_init(); : : /* Save romstage begin */ : timestamp_add_now(TS_START_ROMSTAGE); : : /* System Agent Early Initialization */ : systemagent_early_init(); : : /* PCH Early Initialization */ : pch_early_init(); : : /* Get power state */ : rp.power_state = fill_power_state(); : : /* Print useful platform information */ : report_platform_info(); : : /* Set CPU frequency to maximum */ : set_max_freq(); : : /* Call into mainboard. */ : mainboard_romstage_entry(&rp); : : platform_enter_postcar(); : } : : /* Entry from the mainboard. */ : void romstage_common(struct romstage_params *params) : { : post_code(0x32); : : timestamp_add_now(TS_BEFORE_INITRAM); : : params->pei_data->boot_mode = params->power_state->prev_sleep_state; : : #if CONFIG(ELOG_BOOT_COUNT) : if (params->power_state->prev_sleep_state != ACPI_S3) : boot_count_increment(); : #endif : : /* Print ME state before MRC */ : intel_me_status(); : : /* Save ME HSIO version */ : intel_me_hsio_version(¶ms->power_state->hsio_version, : ¶ms->power_state->hsio_checksum); : : /* Initialize RAM */ : raminit(params->pei_data); : : timestamp_add_now(TS_AFTER_INITRAM); : : romstage_handoff_init(params->power_state->prev_sleep_state == ACPI_S3); : } : It seems these two functions form really just one flow with one mainboard hook pre and one post raminit. With that in mind it makes sense to keep the `romstage_params` declaration here...