Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44076 )
Change subject: soc/intel/common/block/cpu: Refactor init_cpus function
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44076/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44076/4//COMMIT_MSG@12
PS4, Line 12: During
When
Ack
https://review.coreboot.org/c/coreboot/+/44076/4//COMMIT_MSG@13
PS4, Line 13: BS_DEV_INIT_CHIPS (exclude this call if user has selected
nit: add three spaces at the beginning of these lines to align with the rest: […]
Ack
https://review.coreboot.org/c/coreboot/+/44076/4//COMMIT_MSG@19
PS4, Line 19: MTTR
MTRR
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc03090360f34df074b33ba0fced2d192edf068a
Gerrit-Change-Number: 44076
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 31 Jul 2020 09:05:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment