build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )
Change subject: soc/intel/common/block: Provide mmc.c for setting dll registers. ......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35040/9/src/soc/intel/common/block/... File src/soc/intel/common/block/scs/mmc.c:
https://review.coreboot.org/c/coreboot/+/35040/9/src/soc/intel/common/block/... PS9, Line 22: static int mmc_write_dll_reg(void* bar, uint32_t reg, uint32_t val) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/35040/9/src/soc/intel/common/block/... PS9, Line 42: dll_params->emmc_tx_cmd_cntl); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35040/9/src/soc/intel/common/block/... PS9, Line 42: dll_params->emmc_tx_cmd_cntl); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35040/9/src/soc/intel/common/block/... PS9, Line 54: dll_params->emmc_rx_strobe_cntl); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35040/9/src/soc/intel/common/block/... PS9, Line 54: dll_params->emmc_rx_strobe_cntl); please, no spaces at the start of a line