Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33398 )
Change subject: util/amdfwtool: Add multilevel PSP directory table
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33398/1/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/33398/1/util/amdfwtool/amdfwtool.c@546
PS1, Line 546: pspdir2
If this is meant to be updated, should it be on a Flash sector boundary with a round flash sector si […]
Good catch. It's actually aligned when it's created but I'll make it a little more obvious.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33398
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id321f5142e461d4a7f3343c0835a09a1a1128728
Gerrit-Change-Number: 33398
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:51:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment