[coreboot-gerrit] Change in coreboot[master]: arch/x86: Move prologue to .init section

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47599 )

Change subject: arch/x86: Move prologue to .init section
......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/47599/1/src/arch/x86/bootblock_crt0... 
File src/arch/x86/bootblock_crt0.S:

https://review.coreboot.org/c/coreboot/+/47599/1/src/arch/x86/bootblock_crt0... 
PS1, Line 19: #include <cpu/x86/16bit/entry16.inc>
            : #include <cpu/x86/16bit/reset16.inc>
            : #include <cpu/x86/32bit/entry32.inc>
> Section .init description for ELF: […]

Ack

https://review.coreboot.org/c/coreboot/+/47599/1/src/arch/x86/bootblock_crt0... 
PS1, Line 57: .previous
> I might have replicated this from id.S or fit. […]

Done

https://review.coreboot.org/c/coreboot/+/47599/2/src/cpu/x86/16bit/reset16.l... 
File src/cpu/x86/16bit/reset16.ld:

https://review.coreboot.org/c/coreboot/+/47599/2/src/cpu/x86/16bit/reset16.l... 
PS2, Line 61: _bogus2 = ASSERT(_start16bit & 0x80000000, "Invalid linker script");
> Maybe use different assertion error messages to avoid confusion?

Done