Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32252 )
Change subject: mb/intel/icelake_rvp: Add SMI handlers ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32252/5/src/mainboard/intel/icelake... File src/mainboard/intel/icelake_rvp/smihandler.c:
https://review.coreboot.org/c/coreboot/+/32252/5/src/mainboard/intel/icelake... PS5, Line 23: #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC) do we really need to guard this ?