Attention is currently required from: Marshall Dawson, Nikolai Vyssotski, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52745 )
Change subject: device/dram: Add support for LPDDR4 4266 ......................................................................
Patch Set 2:
(3 comments)
File src/device/dram/ddr4.c:
https://review.coreboot.org/c/coreboot/+/52745/comment/ca7415f6_8211f68e PS2, Line 173: /* check for matching DDR4 speed first */ Can we split this into two functions (ddr4, lpddr4) and require the caller to call the right one based on DMI_T17_MEMORY_TYPE? Is this field sometimes wrong?
https://review.coreboot.org/c/coreboot/+/52745/comment/09eb2d46_70d7f1de PS2, Line 175: sizeof(ddr4_speeds)/sizeof(ddr4_speeds[0]));
Prefer ARRAY_SIZE(ddr4_speeds)
Please fix.
https://review.coreboot.org/c/coreboot/+/52745/comment/dae31b35_2ac6b216 PS2, Line 181: sizeof(lpddr4_speeds)/sizeof(lpddr4_speeds[0]));
Prefer ARRAY_SIZE(lpddr4_speeds)
Please fix.