Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop loading changes ......................................................................
Patch Set 46:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/fbbb4820_776e4439 PS46, Line 11: bool aop_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/53099e46_9913fb69 PS46, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/616521e2_6afefe67 PS46, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/fefe16b3_1ab4ec7f PS46, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/04cee0dd_2fb488b8 PS46, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/0f693a9e_eecc5985 PS46, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/13b3f477_d86472c3 PS46, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/b47e0ae6_9501f62f PS46, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/ddcf2efe_5c0366f6 PS46, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/0727f0d1_88759ab2 PS46, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/7ad3c4dc_3f9a4ee7 PS46, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/e5337b7a_f18ca69b PS46, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/8067d303_e60236f4 PS46, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/63a65835_39a99e88 PS46, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/15bce8c4_c1e92cea PS46, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/300823b5_9db2c927 PS46, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/2ff1017c_ab5c882d PS46, Line 23: clock_reset_aop(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/7318cd9a_b440f662 PS46, Line 23: clock_reset_aop(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/bed7f029_c5df98d4 PS46, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/f3fa1042_4a12d916 PS46, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/adaa8dfc_6ef41189 PS46, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/3a85b5ac_f82c1c28 PS46, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/cb99bd4e_2e41ed8a PS46, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/cce0b4c7_30f9fe26 PS46, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/6882b083_5a46a3ce PS46, Line 21: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121762): https://review.coreboot.org/c/coreboot/+/49767/comment/34d7e2f2_0e6cf5e6 PS46, Line 21: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line