Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28935 )
Change subject: nb/i945: Check if IGD is enabled before R/W to dev(0, 2) ......................................................................
Patch Set 1:
(2 comments)
this is not a real issue ... as it will write to nothing when external GPU is used.
https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c... PS1, Line 2306: : : :
But it shows us what to do if.
if "integrated_graphics" is disabled ?
https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c... PS1, Line 2764: pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) & : (DEVEN_D2F0 | DEVEN_D2F1)
Always true?
what I'm trying to explain is : when the chip is not i945GM but a i945G + an external GPU, IGD is disabled. so write to it do not make sense