Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47782 )
Change subject: drivers/i2c/hid: Use ACPI device name if provided by config ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47782/1/src/drivers/i2c/hid/hid.c File src/drivers/i2c/hid/hid.c:
https://review.coreboot.org/c/coreboot/+/47782/1/src/drivers/i2c/hid/hid.c@3... PS1, Line 32: config->
I can't see how we'd end up here in the first place if config were null. […]
Agreed. We typically have a check for NULL in lot of drivers. Also, I think coverity complains about it. But, it shouldn't be the case that dev->chip_info is NULL.