Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37948 )
Change subject: mb/google/puff: [WIP] Add power sequencing for LSPCON
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37948/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/ramstage.c:
https://review.coreboot.org/c/coreboot/+/37948/3/src/mainboard/google/hatch/...
PS3, Line 35: firmware to initialize
which part of the firmware are we waiting for here? the lspcon silicon to settle specifically?
Yes, the LSPCON Firmware. One other solution is to move this sequence to bootblock, so that we have enough time before fsp tries to initialize display.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37948
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I336d8b72fcd44a0d03ee7f277eb5e838e4005804
Gerrit-Change-Number: 37948
Gerrit-PatchSet: 4
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Dec 2019 14:39:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment