Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44254 )
Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................
Patch Set 2: -Code-Review
Patch Set 2: Code-Review+2
We have some other entries in zork which are still using ACTIVE_HIGH for stop_gpio:
git grep "stop_gpio" | grep ACTIVE_HIGH src/mainboard/google/zork/variants/dalboz/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)" src/mainboard/google/zork/variants/morphius/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)" src/mainboard/google/zork/variants/vilboz/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"
Those will have to be audited as well.
I filed an issue for that: https://issuetracker.google.com/163816078