[coreboot-gerrit] New patch to review for coreboot: 317f7bc lenovo/x60/i915.c: Log `PGETBL_CTL` programming

[Paul Menzel]

Paul Menzel ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5934

-gerrit

commit 317f7bccce69acfed9278d0b392d27186c47961d
Author: Paul Menzel 
Date:   Thu Jun 5 09:38:39 2014 +0200

lenovo/x60/i915.c: Log `PGETBL_CTL` programming

Correctly setting up `PGETBL_CTL` is essential for the operating
    system driver to work correctly. Therefore log it more verbosely.

Change-Id: I9b3dfa52f91c13e768c2ef980e5871173a85fcfe
    Signed-off-by: Paul Menzel 
---
 src/mainboard/lenovo/x60/i915.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/lenovo/x60/i915.c b/src/mainboard/lenovo/x60/i915.c
index 8399ae7..ac37467 100644
--- a/src/mainboard/lenovo/x60/i915.c
+++ b/src/mainboard/lenovo/x60/i915.c
@@ -142,13 +142,16 @@ int gtt_setup(unsigned int mmiobase)

write32(mmiobase + GFX_FLSH_CNTL, 0);

+	printk(BIOS_DEBUG, "%s: Write %lx to PGETBL_CTL ...", __func__, pgetbl_ctl);
    write32(mmiobase + PGETBL_CTL, pgetbl_ctl);

/* verify */
-	if (read32(mmiobase + PGETBL_CTL) & PGETBL_ENABLED) {
-		printk(BIOS_DEBUG, "gtt_setup is enabled.\n");
+	pgetbl_ctl = read32(mmiobase + PGETBL_CTL);
+	printk(BIOS_DEBUG, " read back %lx ...", pgetbl_ctl);
+	if (pgetbl_ctl & PGETBL_ENABLED) {
+		printk(BIOS_DEBUG, " GM mappings enabled ... GTT setup successful.\n");
    } else {
-		printk(BIOS_DEBUG, "gtt_setup failed!!!\n");
+		printk(BIOS_DEBUG, " GM mappings disabled ... GTT setup failed.\n");
    	return 1;
    }
    write32(mmiobase + GFX_FLSH_CNTL, 0);