Felix Held has posted comments on this change. ( https://review.coreboot.org/28623 )
Change subject: Add support for Sunsetrise Point LP to inteltool ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28623/1/util/inteltool/inteltool.h File util/inteltool/inteltool.h:
https://review.coreboot.org/#/c/28623/1/util/inteltool/inteltool.h@148 PS1, Line 148: SUNRISEPOINT_LP the device name in the datasheet is "PCH-U with iHDCP 2.2 Premium", so just SUNRISEPOINT_LP isn't specific enough. See https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/7th-... page 23. Would also be good if you add all PCI IDs of the LPC controllers of the PCH SKUs. The PCI ID of the LPC controller is the way to identify the different SKUs. Maybe also try to coordinate the patch with #28618