Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/21112
Change subject: arch/x86/Kconfig: Add warning to config LATE_CBMEM_INIT help text ......................................................................
arch/x86/Kconfig: Add warning to config LATE_CBMEM_INIT help text
The deprecation of late (post-romstage) CBMEM initialization was announced in this blog post: https://blogs.coreboot.org/blog/2017/05/08/announcing-coreboot-4-6/
Arguably, extending the help text of CONFIG_LATE_CBMEM_INIT isn't very useful because neither menuconfig nor nconfig show it for options without a prompt. Therefore, I added warning to the mainboard menu.
Change-Id: I2d21a6ab2fc2811d44fc4febb05841bb2f8d1857 Signed-off-by: Jonathan Neuschäfer j.neuschaefer@gmx.net --- M src/arch/x86/Kconfig M src/mainboard/Kconfig 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/21112/1
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index e18d6d0..418448d 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -125,6 +125,10 @@ early get_top_of_ram() call for romstage. CBMEM tables will be allocated late in ramstage, after PCI devices resources are known.
+ WARNING: Late CBMEM initialization is deprecated. Platforms that + don't support early CBMEM initialization will be removed after + the release of coreboot 4.7. + config PRERAM_CBMEM_CONSOLE_SIZE hex default 0xc00 diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig index bdaa9e7..47338ac 100644 --- a/src/mainboard/Kconfig +++ b/src/mainboard/Kconfig @@ -10,6 +10,9 @@
source "src/mainboard/*/Kconfig"
+comment "WARNING: This mainboard uses LATE_CBMEM_INIT, which is deprecated" + depends on LATE_CBMEM_INIT + config BOARD_ROMSIZE_KB_64 bool config BOARD_ROMSIZE_KB_128